-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Make OutputsSpec::All JSON be "*" not ["*"]
#14528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Make OutputsSpec::All JSON be "*" not ["*"]
#14528
Conversation
If it is a list, then it looks like an output set (`OutputSpec::Names`), but if it is just the string `"*"`, then it is more clearly destinguished from all output sets.
|
I still believe My "esse delendam" aside, this change is good JSON modeling. |
|
Yeah we still need to do the
Rename. It does have one somewhat legit store layer use-case in making a "build all outputs" goal in the
The alternative would be the CLI (or whatever else) doing two
I think so, but I should double check. |
Do we have a real use case for that and is it more than one roundtrip? |
|
The use-case is just the CLI wildcards (and other things grandfathered in like |
Oh hmm, this does affect the |
Motivation
If it is a list, then it looks like an output set (
OutputSpec::Names), but if it is just the string"*", then it is more clearly distinguished from all output sets.Context
#13570
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.